Skip to content

Better filter cloud evals #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2025
Merged

Better filter cloud evals #1634

merged 4 commits into from
Apr 22, 2025

Conversation

@veloce
Copy link
Contributor

@veloce veloce commented Apr 21, 2025 •
edited
Loading

Partially adresses #1623

Changes:

  • cloud evals are not requested if ply > 15 (unless for broadcasts)
  • cloud eval don't override anymore deeper local eval
  • deeper local eval will not override cloud eval
  • local eval will always override cloud eval if search time settings is set to 'infinity'
  • cloud eval will not be requested if a threefold repetition pattern is detected

@fcurts
Copy link

fcurts commented Apr 21, 2025

Any chance to have an “infinite” value to enforce that cloud eval is never used?

@veloce veloce force-pushed the cloud_eval_filter branch from 8933ff4 to 05763f1 Compare April 22, 2025 07:12
@veloce veloce changed the title Add a setting to filter cloud eval by depth Better filter cloud evals Apr 22, 2025
@veloce
Copy link
Contributor Author

veloce commented Apr 22, 2025

I reconsidered the use of a settings here, since I realised the logic to filter out unwanted cloud evals could be improved.

@veloce veloce force-pushed the cloud_eval_filter branch from 3155980 to 1c9af33 Compare April 22, 2025 08:19
@veloce veloce force-pushed the cloud_eval_filter branch from e1164f5 to a0592cc Compare April 22, 2025 09:01
@veloce veloce merged commit 72a8ed5 into main Apr 22, 2025
1 check passed
@veloce veloce deleted the cloud_eval_filter branch April 22, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@veloce @fcurts