-
-
Notifications
You must be signed in to change notification settings - Fork 310
use FadeForwardsPageTransitionBuilder #1685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Last time I introduced it there were bugs; will check if they are fixed now and if so, will merge. Thanks! |
|
Bug is not fixed in the version we're using: flutter/flutter#165681 We'll have to wait for the next stable release. |
Oh, sad. Google IO isn't too far away, though. I understand correctly, lichess app stopped using master flutter channel? |
|
We never used the master channel, but the beta. And indeed there was a bug that impacted us with last beta so I decided to use the stable channel. I found that beta channel was not that useful for us, and flutter team don't even push hot fixes to beta, contrary to the stable one. |
|
I think we should wait for this bug to be fixed too flutter/flutter#164241 |
|
@julien4215, I'm not sure if this makes sense. This behavior is relevant for both the currently used ZoomPageTransitionBuilder and CupertinoPageTransitionBuilder, since they snap the page, actually animating the frozen picture instead of the page. |
Sorry, I didn't get what you said. What behavior are you referring to and how does it relate to the bug I mentioned? |
|
@julien4215, ZoomPageTransitionsBuilder (which is used in lichess now) has a similar problem. But it's faster, and it has less impact on the user. So I agree, let's wait for a fix. I've already discovered how to fix it. |
|
So, can we use this now? |
|
Yes, both fixes are already in the stable channel |
close #1681
compressO-screen-20250502-154430.mp4