Skip to content

Conversation

@TheLastFlame
Copy link
Contributor

close #1681

compressO-screen-20250502-154430.mp4

@veloce
Copy link
Contributor

veloce commented May 2, 2025

Last time I introduced it there were bugs; will check if they are fixed now and if so, will merge. Thanks!

@veloce
Copy link
Contributor

veloce commented May 2, 2025

Bug is not fixed in the version we're using: flutter/flutter#165681

We'll have to wait for the next stable release.

@TheLastFlame
Copy link
Contributor Author

TheLastFlame commented May 2, 2025

Bug is not fixed in the version we're using: flutter/flutter#165681

We'll have to wait for the next stable release.

Oh, sad. Google IO isn't too far away, though.

I understand correctly, lichess app stopped using master flutter channel?

@veloce
Copy link
Contributor

veloce commented May 2, 2025

We never used the master channel, but the beta. And indeed there was a bug that impacted us with last beta so I decided to use the stable channel. I found that beta channel was not that useful for us, and flutter team don't even push hot fixes to beta, contrary to the stable one.

@julien4215
Copy link
Collaborator

I think we should wait for this bug to be fixed too flutter/flutter#164241

@TheLastFlame
Copy link
Contributor Author

TheLastFlame commented May 3, 2025

@julien4215, I'm not sure if this makes sense. This behavior is relevant for both the currently used ZoomPageTransitionBuilder and CupertinoPageTransitionBuilder, since they snap the page, actually animating the frozen picture instead of the page.

@julien4215
Copy link
Collaborator

@julien4215, I'm not sure if this makes sense. This behavior is relevant for both the currently used ZoomPageTransitionBuilder and CupertinoPageTransitionBuilder, since they snap the page, actually animating the frozen picture instead of the page.

Sorry, I didn't get what you said. What behavior are you referring to and how does it relate to the bug I mentioned?

@TheLastFlame
Copy link
Contributor Author

@julien4215, ZoomPageTransitionsBuilder (which is used in lichess now) has a similar problem. But it's faster, and it has less impact on the user. So I agree, let's wait for a fix. I've already discovered how to fix it.

@veloce
Copy link
Contributor

veloce commented May 28, 2025

So, can we use this now?

@TheLastFlame
Copy link
Contributor Author

Yes, both fixes are already in the stable channel

@veloce veloce merged commit 4b41267 into lichess-org:main May 29, 2025
1 check passed
veloce added a commit that referenced this pull request Jun 23, 2025
veloce added a commit that referenced this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use FadeForwardsPageTransition to better match Material Design 3

3 participants