Skip to content

Conversation

@julien4215
Copy link
Collaborator

Close #1321

Copy link
Contributor

@veloce veloce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

A test case is missing. Should be easy to add one since we already have tests for broadcast list and for player search screen.

- Restore page limit which is required for both broadcast list and
  search
- Improve UI for edges cases
@julien4215
Copy link
Collaborator Author

julien4215 commented May 20, 2025

The tests github action is failing because Flutter released a new stable version.

a circular indicator each time a new page is loaded.
@veloce
Copy link
Contributor

veloce commented May 21, 2025

I updated main with new flutter stable version. The conflicts are because of the new code formatting that is applied with dart 3.8. I think you just need to run dart format to fix conflicts @julien4215

@veloce veloce merged commit 6d22af5 into lichess-org:main May 27, 2025
1 check passed
@julien4215 julien4215 deleted the broadcast-search branch June 1, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request: a search field for broadcasts

2 participants