Android adaptive icon cleanup #1875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Such PRs are always appreciated.
Are we supposed to see any visual difference? |
|
Just fyi, I'll be on vacation next week, so I'll merge this PR after that. |
Nope, this basically just removes unused assets. |
|
Merging it then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up Android's legacy app launcher assets in favor of the adaptive icon vector assets that are already present in the app.
Since the minimum SDK is now 26 (where adaptive icons were introduced), we can:
mipmap-anydpi-v26/to justmipmap-anydpi/..webpassets. They are only used on pre-26 devices, which are no longer supported.I also relocated the vector drawable
ic_launcher_foreground.xmlfromdrawable/todrawable-anydpi/to align with convention for vector drawables.Please let me know if you'd like screenshots of these changes going back to API 26. If this PR is merged, I can open a follow-up PR with similar cleanup for other legacy assets.
Note: I did need to run a gradle clean to force AAPT to refresh. Invalidating Android Studio (if you're using that) caches may also be necessary.