Skip to content

Conversation

@tom-anders
Copy link
Collaborator

Partially fixes #585, the bottom bar is still at the very bottom, but we at least use the space on the right hand side more efficiently now.

Before:

Screenshot_1730458251

After:

Screenshot_1730458271

This also affects all other screens that use BoardTable, but I think it looks nice, for example puzzle streak:

Before:

Screenshot_1730458340

After:

Screenshot_1730458306

@veloce
Copy link
Contributor

veloce commented Nov 7, 2024

Looks better, definitely! Perhaps more vertical padding around the move list would help. Here the player widgets look squeezed to the edge.

@tom-anders
Copy link
Collaborator Author

Looks better, definitely! Perhaps more vertical padding around the move list would help. Here the player widgets look squeezed to the edge.

Agreed 👍 or maybe add spacing around the top and bottom player widget instead

@tom-anders
Copy link
Collaborator Author

Added kTabletBoardTableSidePadding around the top and bottom widget, I think this looks very nice:

Screenshot_1731143843

@veloce
Copy link
Contributor

veloce commented Nov 14, 2024

Can you also share a screen recording of a new game showing the move list @tom-anders ? Thanks.

I want to make sure how the move list look like when it is empty (or when it has too few moves to fill all the space).

@tom-anders
Copy link
Collaborator Author

Sure, here's a video of the start of the game, and another one later in the game where the move list starts scrolling

moves1.webm
moves2.webm

@veloce
Copy link
Contributor

veloce commented Nov 18, 2024

Perfect! Thank you!

@veloce veloce merged commit cd13c3a into lichess-org:main Nov 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make board larger on landscape tablets by moving buttons from under the board

2 participants