Skip to content

Conversation

@HaonRekcef
Copy link
Contributor

Adds share URL, download PGN and GIF Options to the broadcast game screen

Preview:

broadcasts-share.webm

Remarks:

  • I refactored the GIF functionality from study into game_share_service and reused it for broadcasts.
  • The broadcast name and round name are not necessary for the URL, but I believe including them is better, as it helps to humanly read the URL.
  • I decided against adding the screenshot position option. I can implement it if you think its needed, but I think this feature is unnecessary on mobile devices.

Copy link
Contributor

@veloce veloce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@veloce veloce merged commit 5622480 into lichess-org:main Dec 11, 2024
1 check passed
@HaonRekcef HaonRekcef deleted the broadcast-share branch December 11, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants