Skip to content

Conversation

@eliahreeves
Copy link
Contributor

Changes made to the edit profile page include:

  • Removed padding from top and bottom outside ListView and added padding inside ListView.
  • Added scroll behavior and GestureDetector to hide keyboard.
  • Refactored to use widgets instead of functions for performance.
  • Made screen pop on successful save.
  • trimmed all text fields before upload.
  • added PopScope to reduce accidental data loss.
    Some kind of dialog should be displayed before exiting, but that will require changing the appbar and I haven't quite figured out all the custom widgets to maintain native feel.

@veloce veloce merged commit 78bed52 into lichess-org:main Dec 17, 2024
1 check passed
@veloce
Copy link
Contributor

veloce commented Dec 17, 2024

Thanks!

I added the confirm dialog here: 6c43166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The biography resets when reducing the keyboard

2 participants