Skip to content

Improve documentation on setting a dev environment #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 12, 2025
Merged

Improve documentation on setting a dev environment #1334

merged 2 commits into from
Jan 12, 2025

Conversation

@julien4215
Copy link
Collaborator

@julien4215 julien4215 commented Jan 2, 2025 •
edited by veloce
Loading

Changes

  • completed the android emulator troubleshooting section
  • added the section on setting up a real device
  • moved the When using a manually installed lila server and When using lila-docker sections that were in Setting up the emulators to the Run section
  • changed the content of When using lila-docker
  • moved some part of Local lila server (manual installation) to Run and also small changes to Run

I also changed the scheme when using a private ip address for the host so that you can connect to a local lila from your android phone without using adb reverse.

@julien4215 julien4215 force-pushed the improve-documentation branch from 2824449 to 97200b9 Compare January 2, 2025 14:15
@julien4215 julien4215 marked this pull request as ready for review January 2, 2025 14:15
@julien4215 julien4215 force-pushed the improve-documentation branch 3 times, most recently from fdf8641 to 7e70963 Compare January 2, 2025 20:46
@julien4215 julien4215 force-pushed the improve-documentation branch from 7e70963 to 0435c9b Compare January 3, 2025 22:26
@veloce
Copy link
Contributor

veloce commented Jan 7, 2025

Can you summarise quickly what are the changes here?

Basically what did you remove, what did you add in this doc? thank.

@julien4215
Copy link
Collaborator Author

julien4215 commented Jan 7, 2025

  • completed the android emulator troubleshooting section
  • added the section on setting up a real device
  • moved the When using a manually installed lila server and When using lila-docker sections that were in Setting up the emulators to the Run section
  • changed the content of When using lila-docker
  • moved some part of Local lila server (manual installation) to Run and also small changes to Run

@veloce veloce merged commit d7fe4e5 into lichess-org:main Jan 12, 2025
1 check passed
@julien4215 julien4215 deleted the improve-documentation branch January 12, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veloce veloce veloce approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@julien4215 @veloce