Skip to content

Fix: Correspondence confirm move behavior #1329 v2 #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Fix: Correspondence confirm move behavior #1329 v2 #1349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/src/view/game/game_body.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ class GameBody extends ConsumerWidget {
materialDifferenceFormat: boardPreferences.materialDifferenceFormat,
timeToMove: gameState.game.sideToMove == Side.black ? gameState.timeToMove : null,
mePlaying: youAre == Side.black,
canGoForward: gameState.canGoForward,
zenMode: gameState.isZenModeActive,
clockPosition: boardPreferences.clockPosition,
confirmMoveCallbacks:
Expand Down Expand Up @@ -167,6 +168,7 @@ class GameBody extends ConsumerWidget {
materialDifferenceFormat: boardPreferences.materialDifferenceFormat,
timeToMove: gameState.game.sideToMove == Side.white ? gameState.timeToMove : null,
mePlaying: youAre == Side.white,
canGoForward: gameState.canGoForward,
zenMode: gameState.isZenModeActive,
clockPosition: boardPreferences.clockPosition,
confirmMoveCallbacks:
Expand Down
4 changes: 3 additions & 1 deletion lib/src/view/game/game_player.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ class GamePlayer extends StatelessWidget {
this.timeToMove,
this.shouldLinkToUserProfile = true,
this.mePlaying = false,
this.canGoForward = false,
this.zenMode = false,
this.clockPosition = ClockPosition.right,
super.key,
Expand All @@ -52,6 +53,7 @@ class GamePlayer extends StatelessWidget {

final bool shouldLinkToUserProfile;
final bool mePlaying;
final bool canGoForward;
final bool zenMode;
final ClockPosition clockPosition;

Expand Down Expand Up @@ -164,7 +166,7 @@ class GamePlayer extends StatelessWidget {
crossAxisAlignment: CrossAxisAlignment.center,
children: [
if (clock != null && clockPosition == ClockPosition.left) Flexible(flex: 3, child: clock!),
if (mePlaying && confirmMoveCallbacks != null)
if (mePlaying && confirmMoveCallbacks != null && canGoForward == false)
Expanded(
flex: 7,
child: Padding(
Expand Down
Loading