Fix iOS broadcast test #1365
Merged
Fix iOS broadcast test #1365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I solved the issue by using the key of the |
|
Not sure to understand what is failing here since the tests pass on CI main branch, and on my machine. |
|
You need to trigger the tests action manually. They were not rerun since the fix was merged on the main branch. |
6c565fd to
9c89e76
Compare
7edcb7d to
334352a
Compare
334352a to
e52197d
Compare
remove useless `mockNetworkImagesFor`
e52197d to
08264c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test for iOS is failing because the finder in
scrollUntilVisibleneeds to match a single element and for iOS there are two text widgets that appears with Completed so I don't know how to fix this test. Maybe we can just remove it or make a separate test for Android and iOS ?