-
-
Notifications
You must be signed in to change notification settings - Fork 310
Add blink effect to next button based on game step cursor #1371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blink effect to next button based on game step cursor #1371
Conversation
|
I'm sure others potentially would like this but from my perspective doesn't the greyed out when at latest move provide enough indication |
|
The grayed-out button provides some indication, but this PR addresses the issue described in #755. In the old mobile app and website, the blinking forward button made it clear when you weren’t on the latest move. Currently, only the countdown timer acts as an alert. If a user is reviewing previous moves and their opponent plays a move, they might think they are still on the current position. The blinking effect helps prevent this confusion and offers a more noticeable visual cue. I’d love to hear any additional suggestions you might have! |
|
That's fair. Originally I was thinking not latest move as in you simply rewinded and were looking on a prior position I didn't quite put enough thought on that a new move has actually been played |
|
Should we also add the same blinking effect to the TV screen where users watch other people’s games live? |
|
I understand the need for a more visible clue that you're not on the last position. I don't really like the blinking though, it is too distracting. The blinking could be replaced with an inverted background color (with opacity) for instance. But the best solution to this issue in my opinion, would be, during a live game, to make the button blink if and only if a new move is received when the user is replaying moves. This is the only moment it is useful because you can't know a new move is added when you're not on the last position. The logic is a little more complex (need to store the move index when starting replaying backwards), but worth it imo. I don't think we should add this logic on TV, it is important enough only when playing (to avoid losing time). |
Agreed, I think it works on the website like this as well.
What about broadcast though? Might be helpful there, especially for long time controls |
…d background effect
|
I removed the blinking effect and replaced it with a background change using opacity. You can adjust the background color and transition duration as you like. A video demonstration is provided below. I modified the logic as follows: If it's my turn and I am reviewing previous moves, the background will flash. In any other case, the background color will not change. Does this approach make sense? Also, as you suggested, I didn’t store the move index. I believe it wasn’t necessary, and I managed to handle it without keeping track of the index. If I misunderstood your point, please correct me. Regarding live TV, there's a bit of a dilemma: from whose perspective should we view it—Black or White? 😄 In what situation should the background flash? 😄 Since it's never our turn, we are just watching! 😄 That being said, could the background flash in live TV mode regardless of the perspective? Screen.Recording.2025-01-29.at.16.30.07.mov |
|
Thanks for the vid! It is much better now. If you managed to do it without an extra variable that is even better (I didn't really think about it so I guess I missed the simpler way to do it with checking it's my turn). |
We should not bother with TV imo. |
Issue: #755
This PR adds a blink effect to the next button when the user is not at the latest move during game reviews.