When game ratingDiff is zero (e.g. draw), color should be yellow instead of red #1382
Conversation
|
Your code is not formatted properly, which is why the tests are failing. You can use |
|
I tried running |
|
The formatter is configured for the project here: Line 29 in de61aa4 Your formatter normally would automatically pick these settings. Or if you run |
|
Hey @cioccarellia, I formatted the code change and updated context. I tested #1497 and added the pull request #1 to your repository. @veloce just a general question, is there a reason/difference behind using context.lichessColors vs LichessColors? AFAIK there is no difference? |
yes because in |
|
@cioccarellia I added a pull request on your repo, reverting the context change. @veloce I appreciate the clarification! I will make sure not to include changes I don't understand in the future. |
reverted from LichessColor to context.lichessColors
In the game UI, when a draw happens between two players, the rating difference is zero.
The game colors the rating diff text with red, but that is inconsistent w.r.t. the home game list, where draw results are shown in yellow.
A more consistent color approach would be to have the zero rating delta in yellow (so that it more accurately represents the rating difference).