Skip to content

Conversation

@nirajk14
Copy link

Closes #2317

@veloce
Copy link
Contributor

veloce commented Nov 3, 2025

Nothing wrong in the code of this PR. But:

@nirajk14
Copy link
Author

nirajk14 commented Nov 3, 2025

Yes, I am able to reproduce it. I decided to show the new game bottom sheet so user can decide the time control and variant to play before game start.
I chose this approach to fix the issue as over the board is separated from the widget that contains the create a game button and the buttons are also far apart. This also doesn't cause any coupling between create a game and over the board.

@veloce
Copy link
Contributor

veloce commented Nov 3, 2025

Closing as the issue is not an issue (cf #2317 )

@veloce veloce closed this Nov 3, 2025
@HaonRekcef
Copy link
Contributor

Maybe we want to show the bottom sheet anyways, as it improves the UX.
Currently the players need to open the a bit hidden menu to change the timecontrol except if they want to play 5+3. (Its not even obvious that its +3 at the beginning of the game)

@veloce
Copy link
Contributor

veloce commented Nov 4, 2025

Yes the UX could be improved for sure. I am open to new suggestions, or PRs, if you feel like it. Note that I also don't like the bottom sheet automatically open if it doesn't allow to start the game in one tap. Which was the case if I'm not mistaken. So I'd accept an UX change, but it'd need to be a little better than just this opening of bottom sheet.

@HaonRekcef
Copy link
Contributor

It seems like the bottom sheet allows to start the game in one tap:

grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Choosing a time from the play button does not apply it to your OTB match. It'll always just start with 5 minutes

3 participants