Add color coding to analysis tree view #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks great! Now that I'm looking at the details trying to understand what changed, I noticed that in old Lichobile the moves are in bold and the move numbers are not. Do you think it'd be worth it to add that as well? |
|
I've made all the main line moves bold, and it does look much better and it gives more clarity to the actual move in the game. @NewSupKaizo55 Preview
|
|
Looks really good! Thanks for your work! |
veloce
reviewed
Jan 18, 2024
| ?.withOpacity(opacity); | ||
|
|
||
| return nag != null | ||
| ? [ |
There was a problem hiding this comment.
I'd extract that in a const.
veloce
approved these changes
Jan 18, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #479
Preview