Clickable AcplChart #483
Merged
Clickable AcplChart #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For longer games the curve might be fine. Should we set a threshold between the curve and no curve or just keep everything not curved? |
|
I also like the curved one more, it looks bit more forgiving. curvednot curvedBut I do not like that it always goes up before going down, look at the end of the game. |
|
If we make it clickable it has to be non curved I guess. For the graph that is still tappable when non on the mainline, I think it's not a problem, you'd just go back to the mainline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #471
I've modified the graph such that it is clickable. It solely depends on the x-value of the touch input. Maybe there is more sophisticated method that involves the distance on the y -axis that works better.
However I observed that the website implementation also considers only the x-value.
Also I changed the graph type to be non-curved. The current curved representation sometimes leads to the maximum not being on a move itself.
To illustrate the difference, please refer to the following videos:
isCurved: true
curved.mp4
isCurved: false
not.curved.mp4
While implementing these changes, I noticed a small "bug." If one promotes a line other than the game to the mainline, the graph still jumps around when pressing it. I'm uncertain about what the intended behavior in this scenario should be. On the website the same "bug" exists. Probably we can just ignore that.