lichess-org · veloce · May 30, 2024 · Feb 24, 2024 · Feb 24, 2024 · Feb 24, 2024
diff --git a/lib/src/model/account/account_repository.dart b/lib/src/model/account/account_repository.dart
@@ -7,8 +7,6 @@ import 'package:lichess_mobile/src/model/common/http.dart';
 import 'package:lichess_mobile/src/model/common/id.dart';
 import 'package:lichess_mobile/src/model/common/perf.dart';
 import 'package:lichess_mobile/src/model/common/speed.dart';
-import 'package:lichess_mobile/src/model/game/archived_game.dart';
-import 'package:lichess_mobile/src/model/game/game_repository.dart';
 import 'package:lichess_mobile/src/model/user/user.dart';
 import 'package:lichess_mobile/src/model/user/user_repository.dart';
 import 'package:logging/logging.dart';
@@ -45,18 +43,6 @@ Future<IList<UserActivity>> accountActivity(AccountActivityRef ref) async {
   );
 }
 
-@riverpod
-Future<IList<LightArchivedGame>> accountRecentGames(
-  AccountRecentGamesRef ref,
-) async {
-  final session = ref.watch(authSessionProvider);
-  if (session == null) return IList();
-  return ref.withClientCacheFor(
-    (client) => GameRepository(client).getRecentGames(session.user.id),
-    const Duration(hours: 1),
-  );
-}
-
 @riverpod
 Future<IList<OngoingGame>> ongoingGames(OngoingGamesRef ref) async {
   final session = ref.watch(authSessionProvider);
@@ -71,7 +57,7 @@ Future<IList<OngoingGame>> ongoingGames(OngoingGamesRef ref) async {
 class AccountRepository {
   AccountRepository(this.client);
 
-  final http.Client client;
+  final LichessClient client;
   final Logger _log = Logger('AccountRepository');
 
   Future<User> getProfile() {

diff --git a/lib/src/model/auth/auth_repository.dart b/lib/src/model/auth/auth_repository.dart
@@ -21,12 +21,12 @@ FlutterAppAuth appAuth(AppAuthRef ref) {
 
 class AuthRepository {
   AuthRepository(
-    http.Client client,
+    LichessClient client,
     FlutterAppAuth appAuth,
   )   : _client = client,
         _appAuth = appAuth;
 
-  final http.Client _client;
+  final LichessClient _client;
   final Logger _log = Logger('AuthRepository');
   final FlutterAppAuth _appAuth;
 

diff --git a/lib/src/model/challenge/challenge_repository.dart b/lib/src/model/challenge/challenge_repository.dart
@@ -1,11 +1,12 @@
 import 'package:http/http.dart' as http;
+import 'package:lichess_mobile/src/model/common/http.dart';
 
 import './challenge_request.dart';
 
 class ChallengeRepository {
   const ChallengeRepository(this.client);
 
-  final http.Client client;
+  final LichessClient client;
 
   Future<void> challenge(String username, ChallengeRequest req) async {
     final uri = Uri(path: '/api/challenge/$username');

diff --git a/lib/src/model/common/eval.dart b/lib/src/model/common/eval.dart
@@ -72,7 +72,10 @@ class ClientEval with _$ClientEval implements Eval {
   }
 
   IList<Move?> get bestMoves {
-    return pvs.map((e) => Move.fromUci(e.moves.first)).toIList();
+    return pvs
+        .where((e) => e.moves.isNotEmpty)
+        .map((e) => Move.fromUci(e.moves.first))
+        .toIList();
   }
 
   @override

diff --git a/lib/src/model/common/http.dart b/lib/src/model/common/http.dart
@@ -81,7 +81,7 @@ Client defaultClient(DefaultClientRef ref) {
 ///
 /// Only one instance of this client is created and kept alive for the whole app.
 @Riverpod(keepAlive: true)
-Client lichessClient(LichessClientRef ref) {
+LichessClient lichessClient(LichessClientRef ref) {
   final client = LichessClient(
     // Retry just once, after 500ms, on 429 Too Many Requests.
     RetryClient(
@@ -178,8 +178,6 @@ class LichessClient implements Client {
       final request = response.request!;
       final method = request.method;
       final url = request.url;
-      // TODD for now logging isn't much useful
-      // We could use improve it later to create an http logger in the app.
       _logger.warning(
         '$method $url responded with status ${response.statusCode} ${response.reasonPhrase}',
       );
@@ -284,16 +282,16 @@ class LichessClient implements Client {
 
     return Response.fromStream(await send(request));
   }
+}
 
-  /// Throws an error if [response] is not successful.
-  void _checkResponseSuccess(Uri url, Response response) {
-    if (response.statusCode < 400) return;
-    var message = 'Request to $url failed with status ${response.statusCode}';
-    if (response.reasonPhrase != null) {
-      message = '$message: ${response.reasonPhrase}';
-    }
-    throw ClientException('$message.', url);
+/// Throws an error if [response] is not successful.
+void _checkResponseSuccess(Uri url, Response response) {
+  if (response.statusCode < 400) return;
+  var message = 'Request to $url failed with status ${response.statusCode}';
+  if (response.reasonPhrase != null) {
+    message = '$message: ${response.reasonPhrase}';
   }
+  throw ClientException('$message.', url);
 }
 
 extension ClientExtension on Client {
@@ -464,29 +462,19 @@ extension ClientExtension on Client {
       );
     }
   }
-
-  /// Throws an error if [response] is not successful.
-  void _checkResponseSuccess(Uri url, Response response) {
-    if (response.statusCode < 400) return;
-    var message = 'Request to $url failed with status ${response.statusCode}';
-    if (response.reasonPhrase != null) {
-      message = '$message: ${response.reasonPhrase}';
-    }
-    throw ClientException('$message.', url);
-  }
 }
 
 extension ClientWidgetRefExtension on WidgetRef {
   /// Runs [fn] with a [LichessClient].
-  Future<T> withClient<T>(Future<T> Function(Client) fn) async {
+  Future<T> withClient<T>(Future<T> Function(LichessClient) fn) async {
     final client = read(lichessClientProvider);
     return await fn(client);
   }
 }
 
 extension ClientRefExtension on Ref {
   /// Runs [fn] with a [LichessClient].
-  Future<T> withClient<T>(Future<T> Function(Client) fn) async {
+  Future<T> withClient<T>(Future<T> Function(LichessClient) fn) async {
     final client = read(lichessClientProvider);
     return await fn(client);
   }
@@ -500,7 +488,7 @@ extension ClientAutoDisposeRefExtension<T> on AutoDisposeRef<T> {
   /// If [fn] throws with a [SocketException], the provider is not kept alive, this
   /// allows to retry the request later.
   Future<U> withClientCacheFor<U>(
-    Future<U> Function(Client) fn,
+    Future<U> Function(LichessClient) fn,
     Duration duration,
   ) async {
     final link = keepAlive();

diff --git a/lib/src/model/engine/uci_protocol.dart b/lib/src/model/engine/uci_protocol.dart
@@ -99,9 +99,9 @@ class UCIProtocol {
         _stopRequested != true &&
         parts.first == 'info') {
       int depth = 0;
-      int? nodes;
+      int nodes = 0;
       int multiPv = 1;
-      int? elapsedMs;
+      int elapsedMs = 0;
       String? evalType;
       bool isMate = false;
       int? povEv;
@@ -130,16 +130,10 @@ class UCIProtocol {
         }
       }
 
-      // Sometimes we get #0. Let's just skip it.
-      if (isMate && povEv == 0) return;
-
       // Track max pv index to determine when pv prints are done.
       if (_expectedPvs < multiPv) _expectedPvs = multiPv;
 
-      if (depth < minDepth ||
-          nodes == null ||
-          elapsedMs == null ||
-          povEv == null) return;
+      if ((depth < minDepth && moves.isNotEmpty) || povEv == null) return;
 
       final pivot = _work!.threatMode == true ? 0 : 1;
       final ev = _work!.ply % 2 == pivot ? -povEv : povEv;

diff --git a/lib/src/model/game/archived_game.dart b/lib/src/model/game/archived_game.dart
@@ -85,6 +85,9 @@ class ArchivedGame
           : white;
 }
 
+/// A [LightArchivedGame] associated with a point of view of a player.
+typedef LightArchivedGameWithPov = ({LightArchivedGame game, Side pov});
+
 /// A lichess game exported from the API, with less data than [ArchivedGame].
 ///
 /// This is commonly used to display a list of games.