Replace defaultTargetPlatform with Theme.of(context).platform #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veloce
reviewed
Feb 5, 2024
lib/src/utils/immersive_mode.dart
Outdated
|
|
||
| Future<void> _setImmersiveMode() async { | ||
| if (defaultTargetPlatform == TargetPlatform.android) { | ||
| if (Theme.of(context).platform == TargetPlatform.android) { |
There was a problem hiding this comment.
In that context I'd not use the Theme.of(context).platform because we're about to make a system call which is only in android. This is not for styling purposes.
Here the docs says is ok to even use dart:io.Platform but I guess we can also use defaultTargetPlatform.
There was a problem hiding this comment.
nice catch! will revert in latest commit
veloce
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #470
Note that in lib/src/utils/layout.dart i changed
final appBarHeight = Theme.of(context).platform == TargetPlatform.iOS ? 44.0 : 56.0;to inside
double estimateRemainingHeightLeftBoard(BuildContext context)to use the
contextforTheme.of(context).platform