-
-
Notifications
You must be signed in to change notification settings - Fork 310
Add clock tool #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clock tool #524
Conversation
|
The app already uses a wake lock. Look at the immersive mode file. You can use that.
|
Thanks for the hint, I added immersive mode to the clock screen 👍🏼 |
|
Looks cool! I was considering implementing this as well, but you beat me to it :) I found a few minor bugs: In reality, 0+1 is 3 seconds +1. Currently, white has to accept their fate and flag. Disabling the reset, settings, and home buttons when the clock is not paused, similar to Lichobile, to prevent accidental clicks seems like a good idea. |
|
Looks nice indeed! I agree with all the above comments from @HaonRekcef
Also since it's a new app, we should change the clock color. We could use another lichess color (defined in |
|
I also think the move counter is weirdly placed here. Could we not just put it just below the clock instead? We can even prepend the string: "Moves played:" before, which is translated. |
c1605ad to
2f05ada
Compare
|
Thanks for all the feedback 🙌🏼
@veloce I am afraid I do not get your point with the move counter - a "move" is completed once both White and Black have played one turn so the same value has to be visible to both players. What do you mean with "below the clock"? Should every player see the move count below his own clock? That would duplicate the information and take up screen space 🤔 |
|
I don't really like the move counter being placed here. But why is that counter useful in the first place? I thought it was only for some special clock setup which is not supported at the moment, isn't it? |
|
To be honest, I migrated the move counter feature and design 1:1 from the old app, because I thought it could be useful to keep track for the 50 move draw rule in longer games. If that's not desired, we can simply remove the feature. |
|
I think we can keep the counter but with a better design. Let's add a move counter, but per player. Each time the clock is tapped the counter increments (independently for each player). Display the move number with a small font at the bottom right corner of each clock button. |
10cc5bd to
bcf7682
Compare
|
Looks very good! Thanks @KarnerTh , I will test it on iOS asap. I think we're missing one last important thing though: the click sound on tap. Let's not bother with the sound themes and use the same sound for all themes. We can reuse the sound of lichobile. |
|
Added the clock sound from lichobile on every tap. Tested only on Android, because I am still not able to run it on iOS - so help is appreciated :) |
I really appreciate the new app and all the work so far, so I would like to contribute to that. I find the clock tool feature from the old app quite useful, so I decided to migrate it to the new app. I tried to reuse as much as possible from the existing codebase and use the same code styles etc. - but I am open for feedback if anything needs to change.
I would love to see the feature in the new app and I hope that other people also find this helpful :)
Features:
Open todos/questions
Screens
Clock screen
Select time options
Time is up