Skip to content

feat: support disabling clock emergency sound #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2024
Merged

feat: support disabling clock emergency sound #792

merged 1 commit into from
Jul 1, 2024

Conversation

@tom-anders
Copy link
Collaborator

@tom-anders tom-anders commented Jun 27, 2024

@tom-anders
Copy link
Collaborator Author

tom-anders commented Jun 27, 2024

(fixed formatting)

veloce
veloce reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@veloce veloce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will wait for the deploy of server change before merging this.

@tom-anders
Copy link
Collaborator Author

tom-anders commented Jun 28, 2024

Thanks for the quick feedback! Addressed all your comments.

@veloce if you don't mind, I might have a look at #759 next, it seems to require similar changes (probably also a similar server change as well

veloce
veloce approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@veloce veloce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@veloce veloce merged commit e8bb9bd into lichess-org:main Jul 1, 2024
@tom-anders tom-anders deleted the clockSound branch July 3, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veloce veloce veloce approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: clock warning sounds

2 participants

@tom-anders @veloce