fix text being cut off in stormNewRun and stormEndRun translations #798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In English, these strings are something like "End run (hotkey: ...)" and
"New run (hotkey: ...)". The previous logic discarded the text in
parenthesis by simply keeping the first two words.
However, in some languages we may have more than two words (e.g. in
German it's "Beende den Run"). With this change, we keep everything
until the '(' character, which should be more robust.
If the string for some reason does not contain '(' at all, split('(')
will return a list containing the string itself, so that will work too.
|
@veloce I haven't included any before/after screenshots, I think the change is trivial enough for that (and seems to also be covered by a unit test). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In English, these strings are something like "End run (hotkey: ...)" and "New run (hotkey: ...)". The previous logic discarded the text in parenthesis by simply keeping the first two words.
However, in some languages we may have more than two words (e.g. in German it's "Beende den Run"). With this change, we keep everything until the '(' character, which should be more robust.
If the string for some reason does not contain '(' at all, split('(') will return a list containing the string itself, so that will work too.