fix incorrect move sounds during analysis #873
Conversation
|
I got curious what lichess.org and the old app do: Turns out they both play actually no sound at all when reverting a move in the analysis board. Doesn't mean the new app has to do the same, I just thought I'd mention this. |
|
To be honest, I did not pay attention to that. I just wanted to start contributing to the new app in some way, and this seemed like a good first issue to solve. |
|
Thanks for your contribution @Lonec-L . I'm still not sure we should merge it because:
|
I think you misunderstood the issue here:
So this PR improves things, but it's still inconsistent with the old app and lichess.org. |
|
Oh my bad, sorry. I really thought that the new app would not play a sound when reverting a move. |
Yeah, so IMO we should be consistent with the old app and Web UI, by not playing a sound at all when reverting a move (instead of fixing the bug). Whats your opinion on this? |
73d4100 to
9de1059
Compare
to match the old app and lichess website
|
I have reverted previous changes and reopened this PR, now with sounds completely removed when reverting moves during analysis, matching the behavior of old app and lichess website. |
|
Ok, thank you for that. I'm still not sure whether no sound when replaying backwards is a good idea. It is like lichess website for sure, but we are allowed to deviate from the website for things like that. I'll think about it. |
|
In the meantime, I'm merging this since it fixes an inconsistency. |
fixes #870
sounds should now be played correctly when user goes to previous or next move on analysis board. The issue was that only associated move of current node (after the requested change) was considered when determining which sound to play. Now the associated move of current node is used when user moves forward through the tree and associated move of previous node (before the requested change) is used when backtracking.
This also fixes move sound not playing when reverting first move of the game. Now the normal move sound is played whenever current node is not a Branch. I am not sure about this, so I am looking for some feedback if this is undesired behavior.