Skip to content

Conversation

@tom-anders
Copy link
Collaborator

Closes #841

shapeColors.webm

@tom-anders tom-anders force-pushed the shapeColors branch 3 times, most recently from 289991b to 61dc83c Compare August 4, 2024 07:56
@tom-anders
Copy link
Collaborator Author

tom-anders commented Aug 4, 2024

Ok, made the following changes:

  1. Using same colors as lichess.org now. IIRC blue, green, red and yellow are the arrow colors supported on the website
  2. Moved the setting to the new "Theme" screen, this way we can add the shapes to the preview board.
  3. Added a colored box to the choice picker entries, although arguably this is now not needed anymore, as the user already gets visual feedback on the preview board.
shapeColors.webm

@veloce
Copy link
Contributor

veloce commented Aug 5, 2024

Great idea to put it in the theme screen! There are some weird conflicts in the game history screen @tom-anders can you see that please?

@veloce
Copy link
Contributor

veloce commented Aug 5, 2024

  1. Added a colored box to the choice picker entries, although arguably this is now not needed anymore, as the user already gets visual feedback on the preview board.

It is still useful for iOS users because the picker will be on a different screen.

Another note: I don't think we should return the / blue color in the settings value preview because:

  1. it is not that clear this is about the color of the arrow
  2. space is constrained on iOS devices and this should be kept short

@tom-anders tom-anders force-pushed the shapeColors branch 2 times, most recently from 5a9f067 to d2b6ba3 Compare August 6, 2024 06:26
@tom-anders
Copy link
Collaborator Author

Another note: I don't think we should return the / blue color in the settings value preview because:

Done!

Also, fixed conflicts now.

@veloce veloce merged commit ae82509 into lichess-org:main Aug 8, 2024
@tom-anders tom-anders deleted the shapeColors branch August 8, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request - Set/change default shape color

2 participants