Challenge from a Position with Fen #804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to create this! Multiple screen recording and remarks as you do are always very appreciated. I'll review it asap but for now I can say it looks very good. |
veloce
reviewed
Jul 3, 2024
| Future<void>? _pendingCreateGame; | ||
| final _controller = TextEditingController(); | ||
|
|
||
| String? textInput; |
There was a problem hiding this comment.
textInput is too vague, prefer, for a local property, a long named describing exactly what it is representing.
| onPressed: timeControl == ChallengeTimeControlType.clock | ||
| ? isValidTimeControl | ||
| ? isValidTimeControl && | ||
| ((textInput != '' && textInput != null) || |
There was a problem hiding this comment.
I think you can use textInput.isNotEmpty instead of comparing with empty string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #797
closes #803
Adds the possibility to challenge another player with a fen:
Behavior with an invalid fen:
invalid.fen.mp4
Behavior with a valid fen:
valid.fen.mp4
Some remarks: