Fix plural handling for zero quantity #808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know about Thanks for catching this. |
veloce
reviewed
Jul 1, 2024
scripts/update-arb-from-crowdin.mjs
Outdated
| }) | ||
| } | ||
| } | ||
| //// add a zero quantity item if it doesn't exist |
There was a problem hiding this comment.
You can delete the block instead of commenting it out.
Me neither until yesterday :D |
|
@tom-anders can you re-run the script to solve the conflicts? thanks |
The removed code in mjs assumed that in all languages `0` is followed by singular but that's not true e.g. for German and English. I tested with French after removing the workaround and updating localizations: `intl.Intl.pluralLogic` seems to handle the plural logic correctly, choosing singular after 0 for French, but plural for German and English. Probably at the time that this code was added, `intl.Intl.pluralLogic` was not used yet...?
Done 👍 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed code in the
mjsfile assumed that in all languages0is followed by singular but that's not true e.g. for German and English.I tested with French after removing the workaround and
updating localizations:
intl.Intl.pluralLogicseems to handlethe plural logic correctly, choosing singular after 0 for French,
but plural for German and English.
Probably at the time that this code was added,
intl.Intl.pluralLogicwas not used yet...?