Refactor TimeIncrement.display Method and Fix Edge Case #823 #834
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
closes #823
This pull request refactors the
TimeIncrement.displaymethod to utilize theclockLabelInMinutesfunction for better readability and maintainability. Additionally, it addresses an edge case noted in issue #823, where non-integer minute values were not displayed correctly. This ensures the correct display of time increments such as1.5+5.Changes Made:
Refactored
TimeIncrement.displayMethod:displaymethod now leverages theclockLabelInMinutesfunction to convert time in seconds to a more readable minute format.Fixed Edge Case:
90+5seconds was incorrectly displayed as1+5instead of1.5+5has been resolved.Added Unit Tests:
time_increment_test.dartto cover the functionality of theTimeIncrementclass.clockLabelInMinutesfunction.Files Modified:
Testing:
clockLabelInMinutesfunction.