Skip to content

Conversation

@jalpp
Copy link
Contributor

@jalpp jalpp commented Apr 12, 2024

add optional field descriptions in properties fixes #159, also added cfc and dsb ratings to bot user to match with user.yaml.

@fitztrev
Copy link
Member

Looks good. The linked issue also mentions the same behavior for title. Could you include that too?

Also for /api/user/{username}, could you move the note from the description of the endpoint to the properties too?

@jalpp
Copy link
Contributor Author

jalpp commented Apr 12, 2024

Looks good. The linked issue also mentions the same behavior for title. Could you include that too?

Also for /api/user/{username}, could you move the note from the description of the endpoint to the properties too?

Sure will do, which notes? The Oauth for following ones?

@jalpp
Copy link
Contributor Author

jalpp commented Apr 12, 2024

Looks good. The linked issue also mentions the same behavior for title. Could you include that too?

Also for /api/user/{username}, could you move the note from the description of the endpoint to the properties too?

finished! I found that streamer doesnt have object type, but Im no so sure how to fix it, I will create an issue for that

@fitztrev fitztrev merged commit 0d654ce into lichess-org:master Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lack of documentation of optional fields in response bodies

2 participants