Implement /master/pgn/{game_id}
#57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The correct return type should be |
|
I don't think I need the |
e2910cd to
f7d9d2b
Compare
f7d9d2b to
49254eb
Compare
|
Thanks! As benediktwerner said, formatting as PGN is necessary otherwise it throws an exception when being called. I've included a test to confirm and fix that. Generally when you're not sure best to test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement
get_otb_master_game=/master/pgn/{game_id}.I did not add a return type for the function as there is no provided way to return
ndjson/jsonin the response, but the response will be a PGN (text) due to the nature of the API endpoint.After merge
Please check off
/master/pgn/{game_id}in issue description of #6.