Skip to content

Implement /api/cloud-eval endpoint #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 3, 2023
Merged

Implement /api/cloud-eval endpoint #62

merged 7 commits into from
Nov 3, 2023

Conversation

@Anupya
Copy link
Contributor

@Anupya Anupya commented Nov 3, 2023 •
edited by kraktus
Loading

Description

  • Add /api/cloud-eval endpoint in the new Analysis class.
  • Added an explanation for PV and CP in the codebase because I had to look them up.
  • Added a test.

After merge

Please check off /api/cloud-eval in #6.

Checklist

Checklist when adding a new endpoint
  • Added new endpoint to the README.md
  • Ensure that my endpoint name does not repeat the name of the client. Wrong: client.users.get_user(), Correct: client.users.get()
  • Typed the returned JSON using TypedDicts in berserk/types/, example
  • Tested GET endpoints not requiring authentification. Documentation, example
  • Added the endpoint and your name to CHANGELOG.md in the To be released section (to be created if necessary) <-- leaving this to the maintainers to do

@Anupya Anupya marked this pull request as ready for review November 3, 2023 19:39
@kraktus kraktus merged commit ee65d42 into lichess-org:master Nov 3, 2023
@kraktus
Copy link
Member

kraktus commented Nov 3, 2023

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Anupya @kraktus