Skip to content

Conversation

@Carbrex
Copy link
Member

@Carbrex Carbrex commented Apr 16, 2024

Closes #7
Closes #8

@Carbrex
Copy link
Member Author

Carbrex commented Apr 16, 2024

Lockfile error happening in tests happened with me too, got fixed by downgrading pnpm to v8.7

@Carbrex Carbrex marked this pull request as draft April 16, 2024 18:09
@Carbrex
Copy link
Member Author

Carbrex commented Apr 16, 2024

image
Also Closes #7

@Carbrex Carbrex marked this pull request as ready for review April 16, 2024 18:56
@Carbrex
Copy link
Member Author

Carbrex commented Apr 16, 2024

I think the failed tests because of pnpm were due to pnpmv9 being used, I should just changed the version used in tests instead of changing the lockfile.

@fitztrev fitztrev merged commit 762381f into lichess-org:main Apr 17, 2024
@fitztrev
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix panic when user clicks "Cancel" during Lichess login Improve design of oauth redirect response

2 participants