Add .pnpm-store volume to docker-compose.yml to get benefits of pnpm #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also one more thing running |
Unintentional when I changed it to work with multiple-word commands in #61 |
|
Thanks. Wonder why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addind pnpm-store to volumes doesn't download the dependencies again and again on running
./lila-docker uiand other command which include pnpm install.Before:
Downloaded packages every time on pnpm install
As far as I understand this is because
docker compose run --rm ui /lila/ui/build --update --clean-build --debug $@makes a new container every time it is run.After:
Just takes the package from pnpm-store directory and doesn't download them again.