Simplify Executor.acquire #267
                
     Merged
            
            
          
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Same aim as in #266.
First, I extracted filtering logic from pattern match by applying
filtermethod before, which also simplified pattern match to 1 case arm. Next I replacedfoldLeft[Option]byreduceLeftOption, a little cleaner, but logic exact the same. And finally, I noticed that after filtering works with_.nonAcquired, them.canAcquire(key)part of if-statement inside always evaluates totruebecause of theWork.Moveimplementation:https://github.com/Masynchin/lila-fishnet/blob/2135cb36973495e55bc8909710063e7f388959e5/app/src/main/scala/Work.scala#L34-L36
So,
reduce's if-statement shortens tom.createdAt.isBefore(a.createdAt), which is just comparing who created earliest. Only thing I don't know what is the logic when twoMove'screatedAtequals, or can it be at all