blog search #499
Merged
blog search #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do we have anything to track down this migration? |
lenguyenthanh
requested changes
Jun 6, 2025
| textField(text), | ||
| shortField(quality).copy(docValues = Some(true)), | ||
| keywordField(language).copy(docValues = Some(false)), | ||
| dateField(date).copy(docValues = Some(true)) |
There was a problem hiding this comment.
Just a curious question, why does some fields keep values, some don't?
There was a problem hiding this comment.
My understanding is that disabling docValues on fields you don’t sort/aggregate keeps segment size smaller. language would only ever be filtered or searched. it wouldn't be sorted.
Co-authored-by: Thanh Le <lenguyenthanh@hotmail.com>
| intro <- doc.getString(F.intro) | ||
| body <- doc.getString(F.markdown) | ||
| author <- doc.getString(F.blog).map(_.split(":")(1)) | ||
| language <- doc.getString("language") |
There was a problem hiding this comment.
Suggested change
| language <- doc.getString("language") | |
| language <- doc.getString(F.language) |
lenguyenthanh
approved these changes
Jun 9, 2025
|
something fishy with git history 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this code assumes the automod subdocument has the integer based "automod.quality" field rather than the string based "automod.classification". data using the older schema is live on prod as of 05/06/2025
that data must be migrated before ublog ingests & queries will function.