Skip to content

Conversation

@TTWNO
Copy link
Contributor

@TTWNO TTWNO commented Jun 7, 2021

This adds three new key combos to enable crazyhouse mode in the NVUI.

  • e/E: get your/opponent's pockets.
  • d: enable drop mode for current tile, use p/n/b/r/q to drop a piece form your pocket.

To use the original-mode input box:

  • p/n/b/r/q@<1-8>
  • m to view your pocket
  • k to view opponent's pocket

@ornicar
Copy link
Collaborator

ornicar commented Jun 7, 2021

No, sorry. I'm no longer accepting extra code complexity for variants. They're incredibly unpopular.

@ornicar ornicar closed this Jun 7, 2021
@TTWNO
Copy link
Contributor Author

TTWNO commented Jun 7, 2021

I'm merely getting the NVUI caught up with the standard version of the game. To be clear, I am not adding new festures, I'm sinply naking existing features for sighted players accessible to those who cannot see.

Is there any circumstance you would accept this functionality? Is there any way I could implement it that would satisy your, totally fair, ideal of keeping code complexity down? Is there an LOC, or similar target that would be considered acceptable?

@ornicar
Copy link
Collaborator

ornicar commented Jun 7, 2021

It's not a goal to have all the website features available with NVUI. There are just too many, most of which I would never accept in the website if they were proposed now. Namely, the niche features that only a small fraction of players use. Such as variants.

Many of the website features are only here because it's almost impossible to remove them. All I can do is avoid having their complexity propagate to new sections, like NVUI.

@TTWNO
Copy link
Contributor Author

TTWNO commented Jun 7, 2021

So far I have just been implementing anyrhing my visually impaired friends ask about when I use.
What are ports to the NVUI that it could use that would be accepted as "necessary" so I don't waste my time in the future?

@ornicar
Copy link
Collaborator

ornicar commented Jun 8, 2021

There are too many for me to list them preemptively. We'll have to evaluate it on a case-by-case basis. I recommend you open a discussion before starting to work on the code. It could be in a new issue.

@allanjoseph98 allanjoseph98 mentioned this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants