Skip to content

Conversation

@Tvallejos
Copy link
Contributor

@Tvallejos Tvallejos commented Jun 29, 2021

Closes #3888

  • highlight own messages
  • highlight host messages

ownmessages

	modified:   chat/src/discussion.ts
	modified:   chat/src/util.ts
	modified:   simul/css/_show.scss
@benediktwerner benediktwerner marked this pull request as draft June 29, 2021 07:41
@benediktwerner benediktwerner marked this pull request as ready for review June 29, 2021 13:20
@benediktwerner
Copy link
Member

benediktwerner commented Jun 29, 2021

Cleaned this up a bit. Not 100% sure about the design aspect though. Here's how it looks:

Screenshot 2021-06-29 151917

The first is for yourself and the second for the simul host.

@Tvallejos Some tips for future PRs:

  • You can create a PR as a draft if it's not finished yet
  • You don't need to put changed files in the description. We can look at the files changed tab on GitHub for that.
  • If a PR fixes/closes an issue, you can use "Closes #issue number" or "Fixes #issue number" so that GitHub will auto-close the issue. Also, you can just use "#issue number" instead of a link.
  • It's a good idea to auto-format your code before creating a PR, either via a Prettier extension in your editor or via yarn run format.

@benediktwerner benediktwerner changed the title [WIP] Enhance chat visibility/user with color Enhance chat visibility/user with color Jun 29, 2021
@benediktwerner benediktwerner changed the title Enhance chat visibility/user with color Highlight yourself and simul host in chat Jun 29, 2021
@Tvallejos
Copy link
Contributor Author

Okay, thanks for the tips. Own messages looks good, but I'm not sure either for host messages

@ornicar ornicar merged commit b5c7e13 into lichess-org:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

highlight simul host in chat

3 participants