Connect external UCI engine #10867
Merged
Connect external UCI engine #10867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: rel attributes for markdown-style links
niklasf
commented
May 7, 2022
app/views/oAuth/authorize.scala
Outdated
| moreJs = embedJsUnsafe( | ||
| // ensure maximum browser compatibility | ||
| """setTimeout(function(){var el=document.getElementById('oauth-authorize');el.removeAttribute('disabled');el.setAttribute('class','button')}, 2000);""" | ||
| """setTimeout(() => {const el=document.getElementById('oauth-authorize');el.removeAttribute('disabled');el.classList.remove('button')}, 2000);""" |
There was a problem hiding this comment.
Intentionally going for much broader browser compatibility here, because apps might open the OAuth prompt in ancient web views.
* master: let mods download games of closed accounts remove paypal checkout live setting
|
Is it ok to merge and deploy this before we have providers? |
|
I would say yes. It's clearly labeled as alpha, so I hope no one will be mad if we change the protocol or disable it again. |
|
This is super cool! Uploading an engine from a .wasm file might be a nice future improvement since it wouldn't need the user to run a WebSocket server locally and would also improve portability. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revives #8400, closes #7909.
Main motivation here is speed, but also that it's unlikely that future Stockfish versions will come with smaller networks that will be (nicely) usable in the browser.
Companion tools: https://github.com/lichess-org/external-engine
Idea:
User downloads and installs remote-uci service (runs WebSocket server in backgound, I guess with a tray icon on Windows/Mac). Currently just prints:
On first install, or on demand,
https://lichess.org/analysis/remote?url=ws://127.0.0.1:9670/<secret>&<engine-info>is opened in the browser.Authorizing creates
ceval.remotewithRemoteWorkerOptsin local storage. Local storage, because likely only the particular device can reach the local remote-uci server. Redirects to the analysis page.On the analysis page:
Settings based on
<engine-info>:secretProtocolshould not rely on Stockfish specifics