Skip to content

Revise 30 move threshold for draw streaks across variants #11580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 2, 2022
Merged

Revise 30 move threshold for draw streaks across variants #11580

merged 12 commits into from
Oct 2, 2022

Conversation

@dignissimus
Copy link
Contributor

@dignissimus dignissimus commented Sep 20, 2022 •
edited
Loading

Resolves #11565 according to https://github.com/dignissimus/lichess-unpackaged/tree/main/game-lengths

I used the modal terminating move number for each variant. Chess960 and Standard remain at 30 moves for consistency. I then rounded move thresholds to the nearest five and bounded them between 10 and 30.

This change is pending comment from the variant team leaders.

Notes

Comments from variant team leaders

Atomic

Message

atomic should be no more than 10, and crazyhouse really shouldn't be more than 20 either

Crazyhouse

Message

atomic should be no more than 10, and crazyhouse really shouldn't be more than 20 either

Horde

Summary

  • The original 50 limit for Horde is reasonable
    • I can potentially revert the 30 move cap

Message

imo 49 is reasonable and could be as high as 60. the way a draw naturally occurs in horde is white promotes but can't mate and black can't trap the queen, these positions take a REALLY long time to get to

ok there's also stalemates ig but those also take a while, maybe 60 is too much

@dignissimus dignissimus force-pushed the revise-thirty-move-draw-streak branch from b71e5c4 to 3499542 Compare September 20, 2022 16:51
@dignissimus dignissimus marked this pull request as draft September 20, 2022 17:44
@benediktwerner
Copy link
Member

benediktwerner commented Sep 21, 2022

iirc it's usually best to not remove dest translation files even though the trans-lint gets mad at it since it creates merge conflicts when pulling new translations after crowdin removed them as well due to the source strings going missing. maybe we should remove the deletion script again 🤔

@ornicar
Revert "Clean translation files"
bda90cd 
This reverts commit 9efe39e.
@ornicar
Merge branch 'master' into revise-thirty-move-draw-streak
48fd7ab 
* master:
  New Crowdin updates (lichess-org#11579)
  revert a couple of color changes in game charts
  prettier
  minor code golf
  i18n: emailConfirmHelp
  advantage & movetimes graph tweaks
  tweak API tournament pairing
  New Crowdin updates (lichess-org#11563)
  Allow quotes to use selection
@ornicar
3check = atomic = 20, simplify code and UI
071c7dc
@ornicar ornicar force-pushed the revise-thirty-move-draw-streak branch from d64e5bb to 071c7dc Compare September 21, 2022 08:19
@ornicar ornicar marked this pull request as ready for review September 21, 2022 08:26
@ornicar ornicar merged commit 0d9dbdc into lichess-org:master Oct 2, 2022
@benediktwerner benediktwerner mentioned this pull request Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adjust draw-streaks move limit in Racing Kings

3 participants

@dignissimus @benediktwerner @ornicar