Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Nov 10, 2022

A couple notes:

  • As a first milestone, this currently only applicable to the the rating history charts on user profile pages.
  • For now, I couldn’t figure out how to make it change color schemes dynamically (light vs. dark), so it requires a reload to apply the theme changes.
  • It still isn’t localized properly (though it seems Plotly.js does support localization).
  • It allows scrolling past the available date range, which can look a bit confusing (I’m not sure Plotly.js has inbuilt functionality to prevent that).
  • The control at the bottom is absent, and so are the intervals buttons at the top.

closes #3509

@ghost ghost marked this pull request as draft November 10, 2022 02:53
@schlawg
Copy link
Contributor

schlawg commented Nov 15, 2022

Looks like progress! To apply themes, look at ui/dasher/background.ts - reloadAllTheThings(). For Plotly - have you tried relayout?

@ghost ghost closed this Jul 28, 2023
@ghost
Copy link
Author

ghost commented Jul 28, 2023

Oops, sorry, I closed it by accident! (Though I made some changes since last time.)

@ghost ghost reopened this Jul 28, 2023
@kraktus
Copy link
Member

kraktus commented Nov 12, 2023

Superseded by #13897, thanks anyway!

@kraktus kraktus closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

replace Highcharts, which is a non-free library

3 participants