Make rating range unselectable for provisional ratings #12342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ea0ea9d to
10124e8
Compare
Those range are ignored anyway by the pairing system. Greying out is better UX than just removing it I think, as with the tooltip they can learn why it's not possible. I'm not sold on the wording of that tooltip, but could not find better without being too lengthy. Fix lichess-org#12271
10124e8 to
5c5248d
Compare
DanielFrantes
approved these changes
Mar 29, 2023
* master: (410 commits) fix broadcast url in zulip logging New Crowdin updates (lichess-org#12695) add seconds to exported date times COPYING file for mpchess (lichess-org#12705) simplify dependency to common%test remove specs2 migrate more tests to munit reorder piece sets run bin/gen/piece-sprites remove unused test fixtures user & api tests with munit migrate modules/game tests to munit migrate modules/common tests to munit Mpchess piece set: bug on wN.svg fixed add mpchess to the piece set list run bin/gen/piece-sprites Fix: PGNs transparent background Bump scalachess fix Crazyhouse checkmate condition Fix depreciation notice about `java.net.Url` Add mpchess piece set ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those range are ignored anyway by the pairing system. Greying out is better UX than just removing it I think, as with the tooltip they can learn why it's not possible. I'm not sold on the wording of that tooltip, but could not find better without being too lengthy.
Fix #12271
NB: I've chosen not to reset the bar to the min/max values as the opacity and pointer are already enough imo