-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
include player info in api/stream/game/{id} #12328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
To at least feign the appearance of consistency, it should probably be more like {
"white": {},
"black": {}
}I guess maybe even just exactly like the game export API: https://github.com/lichess-org/lila/blob/master/modules/api/src/main/GameApiV2.scala/#L291 |
same as board api. hey, they all asked for the moves. also give times because hey free data.
|
I believe the follow up request for adding the moves list was for the "Watch TV" feature of the mobile app to be able to show the move list of the TV game. If the new |
|
Waiting for instructions on the fen, moves, and lastMove field wrt stream delay, but now it looks like this: |
|
I don't see how the new moves field is any better than a stream building it from ndjson. |
* master: export akka.actor.Scheduler New Crowdin updates (lichess-org#12325) read nginx stuffing header fix prev commit Fix eslint accuracy requires analysis Check whether auto comm flags are critical add login monitoring extract linkPopup and apply it to profile links code golf restore enum RateLimit.Result also consider logins from TOR iptrust rate limiter import cats.syntax.all.* More arena and team battle translations (lichess-org#12326) analyser test warning further increase hasher security Translate bell notification sound pref
modules/game/src/main/JsonView.scala
Outdated
| "source" -> game.source, | ||
| "status" -> game.status, | ||
| "createdAt" -> game.createdAt, | ||
| "players" -> players(game) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this breaks the compatibility of many endpoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nevermind, it just reverts a change that was made in the same PR
and should not contain bot/board data in UCI format
|
|
requested for mobile: