Skip to content

Bug fix: Remove alert when successfully completed replayed puzzles #12663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 11, 2023
Merged

Bug fix: Remove alert when successfully completed replayed puzzles #12663

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
44d22f7
removed alert message and changed redirection to dashboard
EnriqueBet Apr 8, 2023
52807b6
modified nextPuzzle redirect path to dashboard
EnriqueBet Apr 10, 2023
779fc6c
added alert back for training themes
EnriqueBet Apr 11, 2023
05956c1
Merge branch 'master' into issue-12332
ornicar Apr 11, 2023
39fedc0
fix puzzle redirect to themes
ornicar Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ui/puzzle/src/ctrl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,8 +347,12 @@ export default function (opts: PuzzleOpts, redraw: Redraw): Controller {
}
redraw();
if (!next) {
alert('No more puzzles available! Try another theme.');
Copy link
Member

@kraktus kraktus Apr 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This not only remove the alert when replaying from the puzzle dashboard, but also when playing a specific theme such as https://lichess.org/training/xRayAttack and no more puzzles are found.
The proper fix would be to detected if the user is replaying a puzzle and do not display the alert only in this case.

If (!data.replay) {
 alert(...)
}

Copy link
Contributor Author

@EnriqueBet EnriqueBet Apr 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback @kraktus I'll take care of it

Copy link
Contributor Author

@EnriqueBet EnriqueBet Apr 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the alert back within an if block as suggested @kraktus

lichess.redirect('/training/themes');
if (data.replay) {
lichess.redirect(`/training/dashboard/${data.replay.days}`);
} else {
alert('No more puzzles available! Try another theme.');
lichess.redirect('/training/themes');
}
}
}

Expand Down