Skip to content

Conversation

@neverRare
Copy link
Contributor

Hello! I made a simple and cute chess piece theme and I'd like it to be added to Lichess :) Licensed under CC BY 4.0

Preview (this is a bit outdated but there's very small difference to what's in the pull request)

chess

Also, I just blindly followed what the other similar pull request have done. I hope this all works 😅 but let me know if there's something needs to be done

@ornicar
Copy link
Collaborator

ornicar commented Apr 4, 2023

These look cute and unique enough to make it to the list!

I have a few comments/requests before we add them:

  • the pieces are too big, they occupy too much space of the square they're on. Here's what the size ratio should be like:

  • the pawns are too big compared to the pieces

  • the white pawns feel bigger than the black ones

  • the black knight eyes should probably be transparent rather than white, or else it would be the only touch of white on the black pieces, and it would look weird on coloured boards.

  • maybe, just maybe, an outline on the black pieces would make them more visible on some boards. It might not work well with the design, so feel free to ignore this.

Please try these suggestions out and show a few screenshots on 2 or 3 different boards! Thank you

@neverRare
Copy link
Contributor Author

awesome! will address these soon :)

@neverRare
Copy link
Contributor Author

neverRare commented Apr 5, 2023

updated now to address your suggestions. how's this?

(the pull request hasn't been updated yet, I'll update it after this has been finalized)

Blue:

blue chess set

Purple:

purple chess set

Brown

brown chess set

I'm actually working on outlined version but it's far from perfect at the moment

@ornicar
Copy link
Collaborator

ornicar commented Apr 5, 2023

These screenshots look good to me! Please update public/piece/kiwen-suwi so we can generate the other files with bin/gen/piece-sprite.

@neverRare
Copy link
Contributor Author

Done! So those parts are automated

ornicar added 3 commits April 5, 2023 13:18
* master:
  more tournament scheduler tests
  test the tournament scheduler - complete
  test the tournament scheduler WIP
@ornicar ornicar merged commit 87e8b90 into lichess-org:master Apr 5, 2023
@neverRare
Copy link
Contributor Author

Oh no, I messed up the files, looks like the black pawn that I've uploaded is larger that what is shown on screenshot. Let me fix it on separate pull request. I'm so sorry!

@neverRare
Copy link
Contributor Author

neverRare commented Apr 6, 2023

By the way, how do I generate the css? Do I just run bin/gen/piece-sprite without any args? (I figured it out, looks like this is how I do it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants