Skip to content

Conversation

@piyush-jaiswal
Copy link
Contributor

@piyush-jaiswal piyush-jaiswal commented Apr 5, 2023

Fixes #12173

Stores the difficulty in cookie, when set by user and uses it to serve puzzles of that difficulty.

I wanted some feedback about my approach and so have opened it in draft mode. Please do share your thoughts!

piyush-jaiswal and others added 2 commits April 5, 2023 16:23
* master:
  handle `-` in piece set name - fixes dasher switch
  generate kiwen-suwi css
  more tournament scheduler tests
  test the tournament scheduler - complete
  test the tournament scheduler WIP
  Update kiwen suwi
  Add kiwen suwi
@ornicar
Copy link
Collaborator

ornicar commented Apr 6, 2023

That's a great way of handling it, thank you!

@ornicar
Copy link
Collaborator

ornicar commented Apr 6, 2023

Upon closer inspection it recomputes a puzzle path for every puzzle, which is very expensive, but I think I can fix that

@ornicar ornicar marked this pull request as ready for review April 6, 2023 08:13
@ornicar ornicar merged commit e3b8b74 into lichess-org:master Apr 6, 2023
@piyush-jaiswal
Copy link
Contributor Author

Thanks for fixing the recomputation :)

@ghost ghost mentioned this pull request Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Puzzles: remember difficulty level

2 participants