Skip to content

Study chapter: fix PGN to clipboard for Safari #12719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Study chapter: fix PGN to clipboard for Safari #12719

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24742ab
better user feedback if copying the chapter PGN fails
kraktus Apr 21, 2023
88aeb12
Study chapter: fix PGN to clipboard for Safari
kraktus Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions ui/analyse/src/study/studyShare.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,19 @@ export function ctrl(
};
}

async function writePgnClipboard(url: string): Promise<void> {
// Firefox does not support `ClipboardItem`
if (typeof ClipboardItem === 'undefined') {
const pgn = await xhrText(url);
return navigator.clipboard.writeText(pgn);
} else {
const clipboardItem = new ClipboardItem({
'text/plain': xhrText(url).then(pgn => new Blob([pgn])),
});
return navigator.clipboard.write([clipboardItem]);
}
}

export function view(ctrl: StudyShareCtrl): VNode {
const studyId = ctrl.studyId,
chapter = ctrl.chapter();
Expand Down Expand Up @@ -150,10 +163,14 @@ export function view(ctrl: StudyShareCtrl): VNode {
title: ctrl.trans.noarg('copyChapterPgnDescription'),
},
hook: bind('click', async event => {
const pgn = await xhrText(`/study/${studyId}/${ctrl.chapter().id}.pgn`);
await navigator.clipboard.writeText(pgn);
(event.target as HTMLElement).setAttribute('data-icon', '');
setTimeout(() => (event.target as HTMLElement).setAttribute('data-icon', ''), 1000);
const iconFeedback = (success: boolean) => {
(event.target as HTMLElement).setAttribute('data-icon', success ? '' : '');
setTimeout(() => (event.target as HTMLElement).setAttribute('data-icon', ''), 1000);
};
writePgnClipboard(`/study/${studyId}/${ctrl.chapter().id}.pgn`).then(
() => iconFeedback(true),
() => iconFeedback(false)
);
}),
},
ctrl.trans.noarg('copyChapterPgn')
Expand Down