In Swiss games, disable draw button on 3-fold repetition and show tooltip (for normal draw too) #12824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ui/round/src/view/button.ts
Outdated
| const enabled = () => !condition || condition(ctrl.data).enabled; | ||
| const hintFn = () => { | ||
| if (!condition) return hint; | ||
| return condition(ctrl.data)?.overrideHint || hint; |
There was a problem hiding this comment.
You can actually do condition.?(..) here to avoid the if.
ui/round/src/view/button.ts
Outdated
| { | ||
| hook: util.bind('click', () => ctrl.socket.sendLoading('draw-claim')), | ||
| attrs: { title: ctrl.noarg('claimADraw') }, | ||
| hook: util.bind('click', () => (condition(ctrl.data).enabled ? ctrl.socket.sendLoading('draw-claim') : () => {})), |
There was a problem hiding this comment.
I don't think you actually want a () => {} here? Just undefined should work, or maybe better to just use an if.
* master: (28 commits) Revet changes to uniboard default width Fix uniboard overflow rename UciToSan code golf add puzzle data to /api/puzzle/activity remove superfluous route (use /api/puzzle/activity instead) add ?before= to /api/user/puzzle-activity delete unused /training/mobile/history provide explorer cache hint also for /opening scala code golf avoid using Map.head Change empty message on explorer max depth fix analysis / change voice icon yarn run format make ExplorerCtrl.cacheUseful a prop provide hint to avoid clobbering explorer cache JsDump.translatedJs: no quantity if there's only 1 3 column layout fix update critical, de dict fix racer websocket connection - broken by dda3f64 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12209
For Swiss tournament games, this PR:
Here's what the UI on a 3-fold looks like:
I haven't figured out how to take a screenshot of the tooltip, any help would be appreciated on that.