Skip to content

Conversation

@TheMadSword
Copy link
Contributor

1- Play your games
2- My tournaments

@ornicar ornicar merged commit d38545c into lichess-org:master Jun 14, 2023
@benediktwerner
Copy link
Member

FYI, if you put Closes #123 or Fixes #123 in the description of your PR, it will link to the corresponding issue and automatically close it when your PR gets merged.

Putting it in the title unfortunately isn't that helpful because it's not linked and it's kinda hard to remember 10k issue numbers 😅

@TheMadSword
Copy link
Contributor Author

TheMadSword commented Jun 16, 2023

FYI, if you put Closes #123 or Fixes #123 in the description of your PR, it will link to the corresponding issue and automatically close it when your PR gets merged.

Putting it in the title unfortunately isn't that helpful because it's not linked and it's kinda hard to remember 10k issue numbers 😅

Oh :o I didn't know that; Good to know! However it seems to need to be in the title and not the description no ? (I just looked at how ornicar did via renaming here : #13029 ; which is in the title)

Thanks ! Nice quick-shortcut to know :) !

EDIT : Found this; all accepted keywords : https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests

@benediktwerner
Copy link
Member

I think Thibault just left it in the title since it was already there. But it only works in the description. You can see that the issue was closed manually, unlike for example #13016 where it indicates that it was closed by the PR merge.

The place where it's in the title is commit messages committed directly to master, but only maintainers can do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants