~Fix tempban negative time (Fixes #13122) #13173
Conversation
f3e5aec to
1685adf
Compare
app/views/lobby/bits.scala
Outdated
| h1(trans.sorry()), | ||
| p(trans.weHadToTimeYouOutForAWhile()), | ||
| p(trans.timeoutExpires(strong(secondsFromNow(ban.remainingSeconds)))), | ||
| p(trans.timeoutExpires(strong(secondsFromNow(ban.remainingSeconds, "reload")))), |
There was a problem hiding this comment.
no need to change secondsFromNow.
You can do secondsFromNow(ban.remainingSeconds)(cls := "extra css classes")
|
The code supposed to automatically reload already exists (and is much simpler): https://github.com/lichess-org/lila/blob/master/ui/lobby/src/ctrl.ts#L101-L103 The question is, why doesn't it work? |
Mmm I'll give a look later. Good point. |
ee794e1 to
9207e42
Compare
9207e42 to
aba747d
Compare
Hi again, The source was a misspelling that happened with commit fd4655c in 2018. PR is fixed. I noticed that locally, once the page is requested, if it takes for instance 15 seconds to load, then the timer will "expire" THEN 15 seconds later the page will reload. I doubt such a behavior would happen in prod (due to fast load); but I'll keep an eye and try to be banned once to test. |
|
good find, thank you. And here's the culprit Line 28 in 572916a |
I don't really see how to solve it without scala (as the tag suggested), without adding very specific selector (in the findAndRender function), so I modified scala to add a css class to make it lighter to read. Tell me if you see another cleaner way of doing it :3 .