Better game phase division in analysis highcharts #13211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
allanjoseph98
commented
Jul 12, 2023
- Currently, the lines drawn for middlegame and endgame are offset by 1. Scalachess starts counting plies at 1 but highcharts lines starts indexing at 0. You can verify this by counting the number of pieces (6 or 10)
- Add a line for the previous phase at the beginning of the chart for partial pgns/ "from positions". I made this study to test them.
- Code golf
|
looking good, let me know when it's ready for review/merge |
Gets messy with fens that don't include ply count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.