~Fix missing shortcuts in analysis & fix flip - Fixes #13332 #13333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siderite
reviewed
Aug 6, 2023
ui/analyse/src/ctrl.ts
Outdated
| this.chessground.set({ | ||
| orientation: this.bottomColor(), | ||
| }); | ||
| if (this.chessground) { |
There was a problem hiding this comment.
Wouldn't just this.chessground?.set... work? On the other side, should the code continue if chessground is not available?
There was a problem hiding this comment.
1- Good point regarding @ '?.' ; I'll change
2- I think logically yes, but maybe people were using that old flipping behaviour before, so I don't change that to not affect their workflow; and the rest doesn't error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~Fix missing shortcuts in analysis (bmir + shift-space + 'enter')
~Fixes flip erroring in /broadcast
Fixes #13332