Remove duplicates between game participants and username search history #13479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earching by username.
|
To reproduce this error:
|
shermansiu
commented
Aug 29, 2023
| } else if (ctrl.data.playerName.previous().includes(name)) { | ||
| return ''; | ||
| } | ||
| return '.button-metal'; |
There was a problem hiding this comment.
Why change the colour for game participants? It seems unnecessary.
There was a problem hiding this comment.
While it would be nice to distinguish between participants whose names are in the search history and those that aren't, using that shade of gray to denote the participants who aren't in the search history can be controversial.
There was a problem hiding this comment.
(Aesthetically-speaking)
There was a problem hiding this comment.
Since users cannot add participants to the search history, it makes sense to gray out a participant if they are not in the search history.
bdffdb5 to
1cb2226
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this example, we are opening up the Personal Opening Explorer player selection modal in the analysis board for Aleksandr vs. Jacob. Aleksandr is already in the search history, whereas Jacob is not.
Before:
After:
Please let me know if you'd like me to swap the colours that I'm using for the game participants and the players in the search history.