Fix key bind for analysis board in blind mode #13431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The fix makes it possible to move pieces on the analysis board in blind mode, similar to how it is implemented on a round board - The issue was coming from the `AnalysisController` stopping key event propagation. The fix adds a `trap_bypass` attribute to the board buttons. Events on elements with this attribute are exempt from being trapped by `mousetrap.ts`
|
Nice, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13165
mousetrap.tsstopping key event propagation. The fix adds atrap_bypassattribute to the board buttons. Events on elements with this attribute are exempt from being trapped bymousetrap.ts